Dt/clean arch #1487
Closed
Dt/clean arch #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps androidx.activity:activity-compose from 1.8.0 to 1.8.2. --- updated-dependencies: - dependency-name: androidx.activity:activity-compose dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Change-Id: I838b81bf8e7fd7cb135f422653a8d8041829b28b
Change-Id: I6742d5e221f86a019f44d3e623609bf76d2a3a2a
Change-Id: Ib1bbe4ad0d823c632d387587aa55c5eeb39e4b8d
Change-Id: Ibf93c1b65250e6527e34bc90602c1b1001b2df46
…i/NiaAppScreenSizesScreenshotTests.kt Co-authored-by: Alex Vanyo <vanyo@google.com>
* main: (37 commits) Disable animations of instrumented tests (android#1167) Bump gradle/wrapper-validation-action from 1 to 2 Remove unused release variable. Fixes android#1231 Apply Composable Parameter Ordering Guidelines Remove kotlinx-coroutines-guava dependency from :sync:work Add explicit guava-android dependency for :sync:work Extract ScreenshotHelper to separate testing module Update AGP to 8.3.0 Remove Insert function - Insert is only used in test. - Upsert do same thing as Insert. 🤖 Updates baselines for Dependency Guard Bump the kotlin-ksp-compose group with 6 updates 🤖 Updates baselines for Dependency Guard Bump hilt from 2.50 to 2.51 Bump com.google.truth:truth from 1.1.5 to 1.4.2 Move java to kotlin folder. Remove disk usage testing Figuring out what is using 66Gb in the runner Dpm Improve converting to kotlin timezone Use trySend multiple times ... Change-Id: If3f564108d42675ba55ef242f0d06f04aff45c4a
Change-Id: I7b2ae264ec84491c847a44869934e2f238564c31
Change-Id: Ibec84b6b58d8e7911057da046bbebddcc32ceb01
Change-Id: I611f73d59790bde240756e8016aa721a1783335f
Change-Id: I9c825c142799cdbb99890d49ded067427cf9fee8
Change-Id: Id9774ad300b04c17cb1d7668c1ab1bac014bf70c
Change-Id: Ic218c6b061b5cea4e56b544073541421862bc1d0
…0.0-alpha08 Update material3-adaptive to 1.0.0-alpha08
Change-Id: Ifb4b44e67df53ddd8ed048122c6c12a904e61528
Update module dependency graphs and add script to create them
Change-Id: I17df9948fed04ddc7ba507b437d39536b8b180bb
Change-Id: Ib6aa372a1ab3b13b5c69c1d3feec2c31e5dca3ce
Made pull request instructions clearer
Regenerate SVG graphs and cleanup/reformat files
…mented-test Move Android instrumented test `ThemeTest` to unit test
Upgrade AGP to 8.4.0, Android Build Tools to 31.4.0, and Gradle to 8.7.
Bumps `hilt` from 2.51 to 2.51.1. Updates `com.google.dagger:hilt-android` from 2.51 to 2.51.1 - [Release notes](https://github.com/google/dagger/releases) - [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md) - [Commits](google/dagger@dagger-2.51...dagger-2.51.1) Updates `com.google.dagger:hilt-android-testing` from 2.51 to 2.51.1 - [Release notes](https://github.com/google/dagger/releases) - [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md) - [Commits](google/dagger@dagger-2.51...dagger-2.51.1) Updates `com.google.dagger:hilt-android-compiler` from 2.51 to 2.51.1 - [Release notes](https://github.com/google/dagger/releases) - [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md) - [Commits](google/dagger@dagger-2.51...dagger-2.51.1) Updates `com.google.dagger.hilt.android` from 2.51 to 2.51.1 - [Release notes](https://github.com/google/dagger/releases) - [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md) - [Commits](google/dagger@dagger-2.51...dagger-2.51.1) --- updated-dependencies: - dependency-name: com.google.dagger:hilt-android dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: com.google.dagger:hilt-android-testing dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: com.google.dagger:hilt-android-compiler dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: com.google.dagger.hilt.android dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Change-Id: Ib871afb7e9f5da3a4240e18062fad9e701c218e7
Remove the printModulePaths task and read modules direct from settings
Add NavigationSuiteScaffold
Bumps `androidxComposeAlpha` from 1.7.0-alpha08 to 1.7.0-beta01. Updates `androidx.compose.foundation:foundation` from 1.7.0-alpha08 to 1.7.0-beta01 Updates `androidx.compose.ui:ui-test-junit4` from 1.7.0-alpha08 to 1.7.0-beta01 --- updated-dependencies: - dependency-name: androidx.compose.foundation:foundation dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: androidx.compose.ui:ui-test-junit4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Change-Id: I0e658d0f311fe0dd71b8cc31f0a678c6bf02712b
…dxComposeAlpha-1.7.0-beta01 Bump androidxComposeAlpha from 1.7.0-alpha08 to 1.7.0-beta01
….51.1 Bump hilt from 2.51 to 2.51.1
…a-01 Update material3-adaptive to beta01
…orkaround Fix state loss with workaround
* 🚧 Kotlin 2.0.0-Beta4 * Testing useKSP2 useK2Uast * KSP 2.0.0-Beta4-1.0.19 * Update lint 8.4.0-alpha13 * 2.0.0-Beta5 * Lint 8.5.0-alpha02 * Update libs.versions.toml * Update libs.versions.toml * 🤖 Updates baselines for Dependency Guard * KSP `2.0.0-Beta5-1.0.20` * 2.0.0-RC1 * lint 8.5.0-alpha06 * Kotlin 2.0.0-RC2 * Lint 8.5.0-alpha07 * Fix missing imports * Migrate from deprecated `kotlinOptions` to `composeCompiler` * Kotlin 2.0.0-RC3 and AGP 8.6.0-alpha01 * Kotlin 2.0.0 & KSP 2.0.0-1.0.21 * Add `.kotlin` directory to `.gitignore` * Migrate from deprecated kotlinOptions to compilerOptions * Restore main workflow * Migrate from deprecated kotlinOptions to compilerOptions * Restore relative directories for Compose compiler metrics & reports --------- Co-authored-by: Don Turner <dturner@users.noreply.github.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
This really needs a bigger refactoring just to compliment the Clean Architecture.
Are part of the Infrastructure Layer and we need to move these outside of the core. Also, there are some Android Frameworks included in the Data layer util and we need to move these Android Frameworks into a separate modules, just being outside of the I'm not sure if they're going to like this. |
|
@JackEblan thanks for the feedback. Just for context (which should have probably been provided in the opening line, my bad/will edit), I'm looking to update not main proper but #1277, which is an exploration of clean architecture prompted by #1273. Neither that nor this are full and final statements on Clean Architecture proper, otherwise those aspects you point out probably should be dealt with as well. |
|
This isn't something we're looking to support/merge for now. If you wish to investigate a clean architecture version of this project please do it on your own fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I have done and why
Updated
dt/clean-archfrom latest main 85129e so that it can continue to be a useful, up-to-date reference in exploring Clean Architecture per #1277 and #1273.It does not look like tests are currently all passing. Possible I'm not configured correctly. In my dev environment, I have above main passing 70/133 tests; prior dt/clean-arch passing 61/120 tests; I'm thinking that's roughly parity with my updates passing 63/106?